Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pkg-config definitions #146

Merged
merged 1 commit into from
Jun 1, 2022
Merged

add pkg-config definitions #146

merged 1 commit into from
Jun 1, 2022

Conversation

guijan
Copy link
Contributor

@guijan guijan commented May 27, 2022

pkg-config makes curlcpp easy to use with non-CMake build systems like the .cmake files make it easy to use with CMake.

I've tested this on OpenBSD.

@JosephP91
Copy link
Owner

Hi @guijan did you performed tests on CMake build sytems after the change? Thanks!

@guijan
Copy link
Contributor Author

guijan commented May 27, 2022

No, I only tried Meson. And good call, because it was broken. I'll work on it more.

@guijan guijan marked this pull request as draft May 27, 2022 20:54
eli-schwartz
eli-schwartz suggested changes May 29, 2022
View reviewed changes
libcurlcpp.pc.in Outdated Show resolved Hide resolved
@guijan guijan force-pushed the add-pkgconfig branch 2 times, most recently from c9c4917 to 55a6ba9 Compare May 30, 2022 05:17
eli-schwartz
eli-schwartz suggested changes May 30, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@guijan
add pkg-config definitions
5711b49 
pkg-config makes curlcpp easy to use with non-CMake build systems like
the .cmake files make it easy to use with CMake.

Done with a lot of help from @eli-schwartz.
@guijan
Copy link
Contributor Author

guijan commented Jun 1, 2022

The initial version must have been the worst PR I have ever sent, but now I think it's in good shape.

I wrote a test project that depends on curlcpp with CMake, Meson, and POSIX Make build definitions: https://github.com/guijan/curlcpp-pc-test
I built commit 5711b49, installed curlcpp to an "install" subdirectory in the source tree by setting CMAKE_PREFIX_PATH from the command line, then exported PKG_CONFIG_PATH to "./lib/pkgconfig" within that subdirectory. With that setup, I've successfully built the test project using all 3 build systems on OpenBSD and Alpine Linux.

@guijan guijan marked this pull request as ready for review June 1, 2022 00:13
@JosephP91 JosephP91 merged commit d867cdc into JosephP91:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guijan @JosephP91 @eli-schwartz